Increase severity of DynamicFindBy rubocop rule #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back in commit 49e55b4 we lowered its severity because there were a few false positives. Back then, I didn't realize we could just whitelist the methods causing false positives. Thanks taitus for the tip.
taitus
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks taitus for the tip.
References
Background
Back in commint 49e55b4 we lowered its severity because there were a few false positives. Back then, I didn't realize we could just whitelist the methods causing false positives.
Objectives
Filter false positives instead of lowering the severity of a rule we apply all the time.
Notes
Thanks @taitus for the tip 😉 🙏 🎉.