Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Consul Democracy 2.1.0 #221
Install Consul Democracy 2.1.0 #221
Changes from all commits
f1ca8a4
7456871
49b5eca
5c4b72b
c44a6ab
59b8bbb
ad38999
659732c
480c7b1
5af53dd
29bc5ba
cb9d2f7
249428f
f289b71
7c646ed
20cd557
e26afe6
4076398
5ce1152
ea4358a
73cfce0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need to add the fnm_command too.
Otherwise, the application crashes in Ubuntu distributions with the ExecJS error we know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that the puma socket was never created, or maybe created and destroyed immediately as the puma task was failing. Maybe now we can wait for the socket to exist in all distributions and not just in Ubuntu 22.04. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the installer, we wait on all distributions thanks to the
or not lookup("env", "CI")
condition. We weren't running this step on Ubuntu 22.04 when using the CI, though; I've just fixed that 👍.