Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that VolumeContentSource is required for pre-populated volumes #404

Open
xing-yang opened this issue Dec 11, 2019 · 1 comment
Open

Comments

@xing-yang
Copy link
Contributor

In https://github.com/container-storage-interface/spec/blob/master/spec.md#createvolume, we have the following:

   // If specified, indicates that the volume is not empty and is
  // pre-populated with data from the specified source.
  // This field is OPTIONAL.
  VolumeContentSource content_source = 4;

The sentence "This field is OPTIONAL" is confusing. It means this field is not required in CreateVolumeResponse in general, however, it is required for pre-populated volume.

Some CSI driver developers found it confusing after we introduced a check to make sure content_source is set for pre-populated volume (kubernetes-csi/external-provisioner#283).

This should be clarified in the CSI spec.

@xing-yang
Copy link
Contributor Author

/assign @xing-yang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant