-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Add --version
flag to print the build info of the binary
#120
Comments
I agree. How much information that "--version" or "-version" should provide? |
Hey @Burning1020 , thanks for your quick response! I am thinking about at least to provide information about the cargo version from env var like Here is an example of how to get these information from git in build time. |
I see. Would you help commit this PR or I can do it lately (got other work to do now) ? |
Sure I can give it a try. Do you think if it's reasonable to add a new flag to https://github.com/containerd/rust-extensions/blob/main/crates/shim/src/args.rs#L24-L42? Also, unrelated to this issue, but what do you think about using clap to build the CLI experience of the shim? |
Yes, maybe there is no other reasonable places.
Clap doesn't support for short flag at present, see here:clap-rs/clap#2468 (comment), so it can't read the flags from containerd. |
It would be nice to have a --version arg for the shims to be able to determine the build version information.
The text was updated successfully, but these errors were encountered: