add unit test coverage in GitHub workflow #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktock
reviewed
Nov 26, 2021
Comment on lines
+24
to
+30
| test-coverage: | ||
| runs-on: ubuntu-20.04 | ||
| name: Coveralls | ||
| steps: | ||
| - uses: coverallsapp/github-action@master | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I don't think we need this in our CI. Users can check the test coverage using go test -cover.
cc @AkihiroSuda
There was a problem hiding this comment.
This thread might be helpful: https://stackoverflow.com/questions/10516662/how-to-measure-test-coverage-in-go
There was a problem hiding this comment.
But thank you very much for your suggestion! 😄
There was a problem hiding this comment.
@ktock Thank you for your feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plug-in added in Github workflow will trigger a comment from coveralls.io when each PR, showing the unit test coverage information and impact on test coverage that PR made.
This will resolve Issue 509