Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] require approvals for PRs #266

Closed
ondrejbudai opened this issue Jan 17, 2024 · 2 comments
Closed

[meta] require approvals for PRs #266

ondrejbudai opened this issue Jan 17, 2024 · 2 comments

Comments

@ondrejbudai
Copy link
Contributor

#263 is now green, and I can actually merge it even without an approval. Can we enable require approvals for this repository?

@runcom
Copy link
Member

runcom commented Jan 17, 2024

@ondrejbudai I've just enabled it, let me know if there's anything I've missed (currently made 1 approval mandatory)

@ondrejbudai
Copy link
Contributor Author

I can no longer merge my PR! \o/ Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants