Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally expose all underlying container metadata in status #348

Open
cgwalters opened this issue Feb 15, 2024 · 6 comments
Open

Optionally expose all underlying container metadata in status #348

cgwalters opened this issue Feb 15, 2024 · 6 comments
Labels
area/cli Related to the client/CLI enhancement New feature or request

Comments

@cgwalters
Copy link
Collaborator

As someone deploying a bootc system, I may want to add custom labels (or OCI annotations) into my image, and I want to be able to see that on the client side to potentially act on it.

Today this is all squirreled away in the underlying ostree-container store, one can extract it with ostree container metadata, but that's awkward and we want to get away from exposing ostree (this also relates to #215 )

Maybe what we do for now is something like bootc status --full which would dump the container manifest and config into the image status?

@cgwalters cgwalters added the enhancement New feature or request label Feb 15, 2024
@cgwalters
Copy link
Collaborator Author

Or maybe it would be better as bootc image inspect or so? If we put it in status, it could get really unwieldy if we have both current and rollback, plus any future lifecycle bound images.

Maybe we should have bootc image list and bootc image inspect in that vein etc.

@sallyom
Copy link

sallyom commented Feb 15, 2024

bootc image inspect could also list configmaps associated with the image (in the future, when configmaps are a thing) and then, would bootc edit support adding custom metadata?

@runcom
Copy link
Member

runcom commented Feb 15, 2024

If we put it in status

@cgwalters what if we namespace the labels with something like ostree.status.whatever... when building the images so we avoid cluttering rpm-ostree status with too many stuff and only show those labels?

@cgwalters
Copy link
Collaborator Author

would bootc edit support adding custom metadata?

Hmm what would be the use case for that? Adding container metadata is a build-time thing right?

@cgwalters what if we namespace the labels with something like ostree.status.whatever... when building the images so we avoid cluttering rpm-ostree status with too many stuff and only show those labels?

The question of exposing container information in rpm-ostree status is something we should probably track in that git repo, not here. It has a similar design shape issue around having it out of band vs inline and size.

@runcom
Copy link
Member

runcom commented Feb 15, 2024

The question of exposing container information in rpm-ostree status is something we should probably track in that git repo, not here. It has a similar design shape issue around having it out of band vs inline and size.

ack, I wrongly thought this was for rpm-ostree status, but it's bootc status, nevermind :)

@sallyom
Copy link

sallyom commented Feb 15, 2024

would bootc edit support adding custom metadata?

Hmm what would be the use case for that? Adding container metadata is a build-time thing right?

right, I was imagining that bootc edit would perform something like a podman commit but didn't really think it all the way through - that would get confusing

@cgwalters cgwalters added the area/cli Related to the client/CLI label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to the client/CLI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants