-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if registries.conf
contains config keys the consumer does not intend to use
#2009
Comments
registries.conf
@rhatdan i know we went around and around on this topic of where do containers-common configuration files land like this. As the user reports, I agree it is unclear. Logically, if we support containers.conf in the macos filesystem, seems we ought to for registries.conf? |
btw, @brurucy excellent writeup. Thank you for taking the time to do so. |
It's technically not possible to support I think we should erase the code paths that lead to the config being loaded on the client side to get rid of the logs. |
Agreed can not do this on the client side. |
Even for containers.conf most options will only be read on the server side. Only exception is the |
I had a look at the exact call path and found that So I want to move the conversation into the direction of how to avoid users from thinking other fields (e.g., registries) could be set on the Mac. Cc: @mtrmac Should Podman be able to specify a slice of supported keys and |
Something like that would be possible, and it would make sense for configs built from scratch. Consider a Linux system, with all the default configs set up for local use of Podman, running Implementation: right now, |
Maybe a debug log plus some doc/man page changes would improve the situation?
We could cache the specified keys to avoid reloading. |
… actually we probably can just read the cache for the warning. |
A friendly reminder that this issue had no activity for 30 days. |
@vrothberg @mtrmac Should this be fixed in containers/image or Podman |
In c/image |
registries.conf
registries.conf
contains config keys the consumer does not intend to use
Feature request description
Assume that the following can be found at $HOME/.config/containers/registries.conf, on macOS:
Running
podman pull --log-level=debug <repo>/<image>
yields the following:Notice how misleading it is to print out that: DEBU[0000] Loading registries configuration "/$HOME/.config/containers/registries.conf"
When on macOS, that is entirely ignored, that is, it will only work as intended, if the user creates a machine with that folder mounted on by default.
Suggest potential solution
To either:
$HOME/.config/containers
when creating a machine, providing the same behaviour across linux and MacHave you considered any alternatives?
Yes. The alternative is to simply create a machine mounting
$HOME//.config/containers
, however, there doesn't seem to be explicit documentation about this. It took a lot of head-banging to figure out thatregistries.conf
just isn't taken into account for Mac.Additional context
I'm fine with tackling either of the solutions I've proposed, but I think that the second one might be easier and faster to put out.
The text was updated successfully, but these errors were encountered: