Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker client code can no longer talk to the latest verson of the docker daemon 25.0.0 #2259

Closed
bainsy88 opened this issue Jan 22, 2024 · 5 comments · Fixed by #2260
Closed
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)

Comments

@bainsy88
Copy link
Contributor

The latest version of the Docker Daemon has now upped the minimum API version to 1.24 via this PR - moby/moby#46887

This now means tools such as skopeo fail against the 25.0.0 docker daemon with the following error

loading image from docker engine: Error response from daemon: client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version

This is caused by the hardcoding of the API version to 1.22 here - https://github.com/containers/image/blob/main/docker/daemon/client.go#L14

This version on the containers/image side has not been updated for 7 years and it is now true that in the case a version is not set the client and daemon will try negotiate an API Version that they both support so that seems a cleaner solution but not sure if there is a good reason why a version would need to be set in this case.

@bainsy88
Copy link
Contributor Author

Added a PR to remove the version pinning as a first pass. Happy to change to pinning at a newer version if there is a good reason to do so.

@mtrmac mtrmac added the kind/bug A defect in an existing functionality (or a PR fixing it) label Jan 23, 2024
@mtrmac
Copy link
Collaborator

mtrmac commented Jan 23, 2024

Thanks! Let’s discuss the details in #2260 .

@dcermak
Copy link
Contributor

dcermak commented Feb 5, 2024

Would it be possible to cut a new release of c/image so that we can get an updated podman, buildah and skopeo out?

@mtrmac
Copy link
Collaborator

mtrmac commented Feb 5, 2024

@dcermak This is already included in a branched release of c/image, and e.g. in Podman 4.9.2, Buildah 1.33.5, Skopeo 1.14.2.

Updating the mainline versions is, I think, currently WIP (around containers/buildah#5286 ), but it will certainly get done in the future.

@dcermak
Copy link
Contributor

dcermak commented Feb 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A defect in an existing functionality (or a PR fixing it)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants