-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netavark 1.8.0
build failure with release vendor crates
#819
Comments
yep. Same here. Need some sleep |
@baude PTAL |
I can reproduce even recreating the vendored deps locally with make vendor-tarball. Seems like cargo-vendor-filterer is replacing required deps for some reason. |
@Luap99 Should it be manually published for aardvark-dns as well ? I suspect same issue will be there. |
Nobody complained there so I don't think it has the same problem, this seem to be a very specific bug around how dependencies and features are resolved. |
Can confirm |
guess we can close this? |
yes, although we should create CI tests for this mechanism to prevent releasing non working assets. |
Build of
netavark 1.8.0
with vendor crates taken from a1.8.0
release fails for me ie (rust 1.72.1
):Build succeeds if crates are vendored with
cargo vendor
(comparing contents ofcargo vendor
output andnetavark-v1.8.0-vendor.tar.gz
shows many differences).The text was updated successfully, but these errors were encountered: