Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the Windows storage driver? #2009

Open
mtrmac opened this issue Jul 10, 2024 · 2 comments
Open

Delete the Windows storage driver? #2009

mtrmac opened this issue Jul 10, 2024 · 2 comments

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Jul 10, 2024

Ever since 1eba391 in Sep 2017 the driver’s test can’t compile because a addAceToSddlDacl function is missing.

Clearly no-one is even trying to make it functional.

Can we remove that code? If we ever did want to add a Windows support, the old code can always be fished out of git.

@rhatdan
Copy link
Member

rhatdan commented Jul 11, 2024

SGTM

@nalind
Copy link
Member

nalind commented Aug 7, 2024

That call is in the unit test which only run on Windows, so CI doesn't run them. The driver itself compiles, for whatever that's worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants