-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling and pass error to the parent process and/or caller of libcontainer #2389
Comments
Example where this error message was confusing: containerd/runwasi#326. There were other issues in the way we consumed the api's but I was expecting the error returned to be an error based on the validation code, i.e was expecting |
👍 |
This is one of the most important features for us. It may seem surprising, but it will probably be a unique feature not found in any runtime. |
May I ask if there's any workaround for now to get the error message? |
@peter-jerry-ye You can get the error message with bpftrace. |
I think in my PRs for dbus and rootless related changes, I have covered most of the cases where we can catch and return errors from init process. I'll take another look to see if there are any remaining places and close this issue if not. |
If the init process errors, we currently close the channel and exit. The only context around the error are in the logs/traces. This is not good UX for libcontainer interface. A better design is to return error through the channel back to the parent process so the parent process can log it and/or return to the caller.
The text was updated successfully, but these errors were encountered: