Migrate integration test to use tempfile #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihuaf <yihuaf@unkies.org>
4 tasks
yihuaf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of switching to the
tempfilecrate. The integration test migration is mostly straight forward. Previously, we use container id as the bundle name. Now we use a random name from thetempfileas the bundle path. There is no hard requirement that the bundle path name has to be the container id (uuid), so we are fine here. Also, since the bundle path prepared usingtempfile, it will be cleaned up regardless if test success or fails. So we are safe to make the change.There are some minor edits to the tests I tagged along. It is small enough that I am too lazy to separate out as a different PR :)