Support Host NetworkMode for ECS provider #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriggaHel
force-pushed
the
support-ecs-host-network-mode
branch
from
ff6c84a
to
7326e02
Compare
ldez
changed the title
FriggaHel
force-pushed
the
support-ecs-host-network-mode
branch
from
7326e02
to
79fd9e7
Compare
mmatur
requested changes
Oct 26, 2017
docs/configuration/backends/ecs.md
Outdated
| @@ -129,6 +129,7 @@ Labels can be used on task containers to override default behaviour: | |||
| | `traefik.protocol=https` | override the default `http` protocol | | |||
| | `traefik.weight=10` | assign this weight to the container | | |||
| | `traefik.enable=false` | disable this container in Træfik | | |||
| | `traefik.backend.port=80` | override the default `port` value. Overrides `NetworkBindings` from Docker Container | | |||
There was a problem hiding this comment.
Could you please use LabelPort instead of creating a new label.
provider/ecs/ecs.go
Outdated
| @@ -554,6 +554,9 @@ func (p *Provider) getHost(i ecsInstance) string { | |||
| } | |||
|
|
|||
| func (p *Provider) getPort(i ecsInstance) string { | |||
| if port := p.label(i, types.LabelBackendPort); port != "" { | |||
There was a problem hiding this comment.
Could you please use types.LabelPort instead of creating a new label.
types/common_label.go
Outdated
| @@ -24,6 +24,7 @@ const ( | |||
| LabelTraefikFrontendWhitelistSourceRange = LabelPrefix + "frontend.whitelistSourceRange" | |||
| LabelBackend = LabelPrefix + "backend" | |||
| LabelBackendID = LabelPrefix + "backend.id" | |||
| LabelBackendPort = LabelPrefix + "backend.port" | |||
There was a problem hiding this comment.
Could you please use types.LabelPort instead of creating a new label.
FriggaHel
force-pushed
the
support-ecs-host-network-mode
branch
from
79fd9e7
to
f6ef44b
Compare
|
Can you release that sooner than 1.5? That's not a big change, right? |
|
@zyzop the releases on 1.4 branch are only for bug fixes and documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Allows to override exposed port by Label (
traefik.port) when using ECS provider.This add ability to use traefik with containers running with Host NetworkMode (#2169)
Fixes #2169