Add non regex pathPrefix #2592
Merged
Add non regex pathPrefix #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoDE
approved these changes
Dec 19, 2017
timoreimann
suggested changes
Dec 19, 2017
server/rules.go
Outdated
| @@ -54,11 +54,25 @@ func (r *Rules) path(paths ...string) *mux.Route { | |||
| func (r *Rules) pathPrefix(paths ...string) *mux.Route { | |||
| router := r.route.route.Subrouter() | |||
| for _, path := range paths { | |||
| router.PathPrefix(strings.TrimSpace(path)) | |||
| cleanPath := strings.TrimSpace(path) | |||
| if strings.Contains(cleanPath, "{") { | |||
There was a problem hiding this comment.
Can we leave a note here why { is important?
emilevauge
force-pushed
the
add-non-regex-pathprefix
branch
from
b020fbb
to
e98673d
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
traefiker
force-pushed
the
add-non-regex-pathprefix
branch
from
e98673d
to
0a1578a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds non regex
PathPrefix&PathPrefixStripsupport.When no
{character is found in the given path, we now bypass thegorilla/muxregex implementation to use our lightweight implementation instead.Motivation
Fixes #2376
More
Additional Notes
The leading & trailing slash behavior has been tested to be the same as before.