-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global InsecureSkipVerify option to disable certificate checking #557
Conversation
Hi Stuart, Thanks for the PR :) Could you gofmt your code please. |
Sorry for taking a while to respond. That is now fixed |
Thanks @stuart-c ! |
Signed-off-by: Stuart Clark <stuart.clark@Jahingo.com>
d6f3bd3
to
4a88cbd
Compare
Done |
LGTM |
My only question is about the name of the flag that feels a little bit weird : I would either have a I'm bad at naming things though 😅 |
I just used the Go naming, but that's easily changed... |
We already use this naming in providers, I think we should stay consistent and leave it :) |
Good point, LGTM then 👼 |
Signed-off-by: Stuart Clark stuart.clark@Jahingo.com