Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global InsecureSkipVerify option to disable certificate checking #557

Merged
merged 3 commits into from
Aug 1, 2016

Conversation

stuart-c
Copy link
Contributor

Signed-off-by: Stuart Clark stuart.clark@Jahingo.com

@errm
Copy link
Contributor

errm commented Jul 25, 2016

Hi Stuart,

Thanks for the PR :)

Could you gofmt your code please.

@stuart-c
Copy link
Contributor Author

Sorry for taking a while to respond. That is now fixed

@emilevauge
Copy link
Member

Thanks @stuart-c !
Could you add some documentation in https://github.com/containous/traefik/blob/master/traefik.sample.toml, and in https://github.com/containous/traefik/blob/master/docs/toml.md ?
And you need a new rebase ;)

@stuart-c
Copy link
Contributor Author

Done

@emilevauge
Copy link
Member

LGTM
thanks @stuart-c :)
/cc @containous/traefik

@vdemeester
Copy link
Contributor

My only question is about the name of the flag that feels a little bit weird : I would either have a Insecure one (like the --insecure flag of curl) or a TLSSktipVerify or CertificateSkipVerify or..

I'm bad at naming things though 😅

@stuart-c
Copy link
Contributor Author

stuart-c commented Aug 1, 2016

I just used the Go naming, but that's easily changed...

@emilevauge
Copy link
Member

We already use this naming in providers, I think we should stay consistent and leave it :)

@vdemeester
Copy link
Contributor

We already use this naming in providers, I think we should stay consistent and leave it :)

Good point, LGTM then 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants