Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example code for tutorial #188

Merged
merged 7 commits into from
Jan 22, 2021

Conversation

FLoppix
Copy link
Contributor

@FLoppix FLoppix commented Jan 20, 2021

Add the example code for the blog post metrics tutorial

@FLoppix FLoppix requested a review from andipaetzold January 21, 2021 11:29
@FLoppix FLoppix force-pushed the feat/add-example-code-for-tutorial-app branch from af6fc13 to 4069ee3 Compare January 22, 2021 11:35
Copy link
Contributor

@VaguelySerious VaguelySerious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: your linter seems inconsistent. After the last changes we have mixed single and double quotes depending on the file.

@FLoppix FLoppix merged commit f49553e into master Jan 22, 2021
@FLoppix FLoppix deleted the feat/add-example-code-for-tutorial-app branch January 22, 2021 13:30
it("Component text exists", () => {
const { getByText } = render(<Sidebar />);

expect(getByText("Hello Sidebar Component")).toBeInTheDocument();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's this test passing? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are not running tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants