-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern esm support #438
modern esm support #438
Conversation
883e962
to
21e0ac2
Compare
…lean up dependencies
…with Vitest - providing CJS variants will now be responsability of our actual SDKs
…rsion supporting node v18.0
b6f1d86
to
82f8e2a
Compare
14e9797
to
665e5d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks great to me! This is a significant improvement and jumps out to me as a methodical approach to making it happen.
A few questions I have about the outstanding work:
- This is a semantic version major/breaking release yes? Seems obvious but I'm not sure we've discussed it.
- What is your thought on the testing process for this? I'd love to be able to deploy a canary/beta version of this for testing (+the CMA/CDA js changes), and can help out with that if so, though I don't have much experience working in this repo generally. I can also help out with some manual testing as needed.
Yes, definitely a breaking change!
I am testing currently extended on a local verdaccio server. As soon I am happy with it, I'll fix all the urls in the lock files to use public servers and we can deploy a public alpha version! |
fd38be5
to
6d60fe5
Compare
Will fix: |
fix: force release
fix: force release
fix: branch name
This is published as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, missed a review here but I think this is still looking good since the last time
@mgoudy91 isnt the contenful.js already released using this? We probably should release this then as well. |
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR, building upon #437, introduces comprehensive and up-to-date ESM support for the SDK-CORE, CMA, and CDA libraries.
Our goal is to transition these user-facing libraries to dual packages (both CommonJS and ESM compatible) as outlined in the Node.js documentation, with an added browser bundle for broader accessibility.
The SDK core will adopt an ESM-only format to guarantee compatibility with ESM-only dependencies, catering to our diverse range of customers by ensuring optimal usability across various JavaScript environments.
Complementary PRs for CDA and CMA are forthcoming. There's a potential need to standardize the CDA and CMA libraries on TypeScript and webpack for consistency, which I believe is crucial.
Change Summary
package.json
for better clarity.prepublish
script issue, which executed on every install.Where we have to be careful