Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradio 4. forge #211

Open
githabtane opened this issue Jul 27, 2024 · 7 comments · May be fixed by #215
Open

Gradio 4. forge #211

githabtane opened this issue Jul 27, 2024 · 7 comments · May be fixed by #215

Comments

@githabtane
Copy link

Expected behavior

I want it to be compatible with Gradio 4. Forge

@jisdf
Copy link

jisdf commented Jul 29, 2024

me too
微信截图_20240729103537

@altoiddealer
Copy link

Believe it or not, the fix for this particular issue is actually very simple.

It may be a Forge specific issue... not the fault of Gradio 4...

For some reason, components that inherit from the main component class do not register correctly.
Components which are direct instances like button = ToolButton() have no issue at all, while button = CustomButton() and CustomButton(ToolButton) get screwed.

In regards to this extension, the author went out of their way to make a custom instance.

The solution is to delete the custom ToolButton() and simply import it

from modules.ui_components import FormRow, ToolButton

Then just make that one button like this:

sam_refresh_models = ToolButton(value=refresh_symbol, variant="tool")

There is another hurdle to jump over though, as something else is deprecated... after trying to run a segmentation from points:

Screenshot 2024-08-24 233551

This one is probably also simple to get around...

Unfortunately, the author is unresponsive though? So no one would even merge these fixes?

@continue-revolution
Copy link
Owner

I am very busy recently. However, if someone can make a PR, I will merge as soon as I can.

@altoiddealer
Copy link

Oh mb! BTW I remember my excitement of seeing your Reddit post way back when you first made this extension, my mind was blown when I first used it (still is when using it).

I’ll see if I can debug the remaining issues and send a PR

@altoiddealer
Copy link

I've solved most of the main functions, and checked that they are working between both A1111 and new Forge.

Trying to work out a few last things not working in Forge... specifically, all these

Screenshot 2024-08-25 112512

@altoiddealer
Copy link

Actually, everything seems to be working

@dncainiao
Copy link

Actually, everything seems to be working
Awesome, the update you made works relatively perfectly, thank you so much!
太棒了,你做的更新可以比较完美的运行,感谢你啊,太感谢了

下面是大佬的fork地址,记得点个小星星啊
Here is the big brother's fork address, remember to point a star :
https://github.com/altoiddealer/sd-webui-segment-anything-altoids/tree/work_in_forge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants