Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback locales list always contains extension default value #31

Closed
rozsival opened this issue Oct 21, 2020 · 1 comment
Closed

Fallback locales list always contains extension default value #31

rozsival opened this issue Oct 21, 2020 · 1 comment

Comments

@rozsival
Copy link
Member

As of v0.7.0 the DI extension defines ['en_US'] as a default value for translation.locales.fallback.

Due to this issue / behavior of nette/schema, the default value is always present in the configured list of fallback locales. This is unwanted behavior as applications without en_US locale should never have it as a fallback.

Maybe fe0fae7 could be reverted to the previous implementation?
@aleswita
Copy link
Member

Thank you for report, this is realy unexpected.. fixed in 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleswita @rozsival