Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.0 #187

Merged
merged 4 commits into from
Jul 30, 2024
Merged

0.10.0 #187

merged 4 commits into from
Jul 30, 2024

Conversation

PierreMartinon
Copy link
Member

@PierreMartinon PierreMartinon commented Jul 29, 2024 •
edited
Loading

  • improved NLP variables layout (interlaced X,U)
  • minor API change: split docp and nlp from direct transcription
  • new format for tests and test problems (closer to OptimalControl)

@PierreMartinon PierreMartinon mentioned this pull request Jul 29, 2024
Merged
jbcaillau
jbcaillau reviewed Jul 30, 2024
View reviewed changes
src/problem.jl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PierreMartinon do you think interlacing X and U improves structure / sparsity pattern / performance?

Copy link
Member Author

@PierreMartinon PierreMartinon Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sparsity is more diagonal this way, with the previous 'X followed by U' we had something like 2 diagonal bands side by side. Benchmark seemed to indicate a small improvement, maybe 10% faster. As mentioned in the other thread we can try several layouts and see how it goes.

@jbcaillau jbcaillau merged commit a9ae483 into main Jul 30, 2024
3 checks passed
@jbcaillau jbcaillau deleted the 0.10.0 branch July 30, 2024 21:17
@PierreMartinon
Copy link
Member Author

PierreMartinon commented Jul 31, 2024 •
edited
Loading

@JuliaRegistrator register()

edit: ok, need to comment on the commit itself, not the PR here

@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

1 similar comment
@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbcaillau jbcaillau jbcaillau approved these changes

@joseph-gergaud joseph-gergaud Awaiting requested review from joseph-gergaud

Assignees

@PierreMartinon PierreMartinon

@joseph-gergaud joseph-gergaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PierreMartinon @JuliaRegistrator @jbcaillau @joseph-gergaud