Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub App Auth for ResourceSet provider #168

Open
tplass-ias opened this issue Feb 12, 2025 · 1 comment · May be fixed by #173
Open

GitHub App Auth for ResourceSet provider #168

tplass-ias opened this issue Feb 12, 2025 · 1 comment · May be fixed by #173
Labels
area/resourceset ResourceSet related issues and PRs enhancement New feature or request

Comments

@tplass-ias
Copy link

tplass-ias commented Feb 12, 2025 •
edited
Loading

For better security/api limits/etc, please support GitHub app auth. I noticed in the first implementation of ResourceSets and preview envs for PR's, it only accepts a GitHub PAT: #143

Some docs from GitHub:
@stefanprodan stefanprodan changed the title GitHub App Auth for ResourceSets/receivers GitHub App Auth for ResourceSet provider Feb 12, 2025
@stefanprodan stefanprodan added enhancement New feature or request area/resourceset ResourceSet related issues and PRs labels Feb 12, 2025
@stefanprodan
Copy link
Member

After Flux 2.5 release which will come with support for GitHub App, we could consider implementing it in Flux Operator.

@matheuscscp matheuscscp linked a pull request Feb 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/resourceset ResourceSet related issues and PRs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GitHub App authentication for ResourceSetInputProvider API controlplaneio-fluxcd/flux-operator
2 participants
@stefanprodan @tplass-ias