Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@commitlint/cli still depends on core-js 2 #1531

Closed
1 of 4 tasks
calvinl opened this issue Apr 14, 2020 · 2 comments · Fixed by #2697
Closed
1 of 4 tasks

@commitlint/cli still depends on core-js 2 #1531

calvinl opened this issue Apr 14, 2020 · 2 comments · Fixed by #2697
Labels
dependencies Pull requests that update a dependency file

Comments

@calvinl
Copy link

calvinl commented Apr 14, 2020

When installing from npm, version 8.3.5 of @commitlint/cli has different dependencies than the ones in this repo (still marked at 8.3.5).

The current package published on npm spits out a warning about core-js:

warning @commitlint/cli > babel-polyfill > core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning @commitlint/cli > babel-polyfill > babel-runtime > core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Expected Behavior

A new version should be published on npm with the updated dependencies.

Current Behavior

The dependency mismatch causes warnings when installing.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Publish a new version.

@shirotech
Copy link

I did a bit of digging, it seems like there is an odd package vorpal that depends on babel-polyfill that depends on core-js@2 https://unpkg.com/browse/babel-polyfill@6.26.0/package.json

Perhaps the maintainers have more insights into this.

@escapedcat
Copy link
Member

Vorpal is used in the @commitlint/prompt package at the moment. We would like to get rid of it but not sure when we get to it. See: #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
3 participants