Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(is-ignored): use grouped regex to ignore merge commits #439

Merged
merged 1 commit into from
Sep 15, 2018
Merged

fix(is-ignored): use grouped regex to ignore merge commits #439

merged 1 commit into from
Sep 15, 2018

Conversation

byCedric
Copy link
Member

Description

Fixes #417

Motivation and Context

Usage examples

How Has This Been Tested?

I've added a test case which should return false according to the issue description.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marionebl marionebl merged commit 905e9d5 into conventional-changelog:master Sep 15, 2018
@marionebl
Copy link
Contributor

Thank you!

@byCedric byCedric deleted the fix/ignore-regex branch September 15, 2018 09:35
@byCedric byCedric mentioned this pull request Oct 4, 2018
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong regexp
2 participants
@byCedric @marionebl