Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cli deploy): bump storybook-deployer to 2.8.8 #145

Conversation

dominik-stypula-polcode

Related to the latest fix in storybook deployer: storybook-eol/storybook-deployer#102

@lkraav
Copy link

lkraav commented May 13, 2021

  1. This is chore, avoid inventing random. See https://github.com/commitizen/cz-cli

Commitize

  1. Scope can only be something in packages/, or empty for global things. There is no "cli deploy" package. This is chore(storybook)

@dominik-stypula-polcode
Copy link
Author

  1. This is chore, avoid inventing random. See https://github.com/commitizen/cz-cli

Commitize

I actually use Git Commit Template plugin in PHPStorm for this, which has the following list of commit types, that is where the build type comes from

Screenshot from 2021-05-13 10-23-10

@lkraav
Copy link

lkraav commented May 13, 2021

I actually use Git Commit Template plugin in PHPStorm for this, which has the following list of commit types, that is where the build type comes from

Repo makes the call of what gets in, IDE can't dictate it because not everybody commits in IDE.

I'm surprised commit linter allowed this message to pass, configuration is not as strong as it needs to be.

"Unknown" build type is the smaller issue than missing proper scope storybook package.

@lkraav
Copy link

lkraav commented May 13, 2021

Indeed build is listed in https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional README is interesting, taking a closer look.

Copy link

@lkraav lkraav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase on latest commitlint change, I think it should auto-check packages/ scope, and auto-allow empty scope as well now 👍

@lkraav
Copy link

lkraav commented May 13, 2021

/rebase

@github-actions github-actions bot force-pushed the storybook-deployer-bump-2-8-8 branch from 03ba1d0 to 7843fe5 Compare May 13, 2021 12:53
@lkraav lkraav force-pushed the storybook-deployer-bump-2-8-8 branch from 7843fe5 to 2b9031b Compare May 13, 2021 13:18
@lkraav lkraav closed this in 2b9031b May 13, 2021
@lkraav lkraav merged commit 59b1591 into conversionxl:master May 13, 2021
@lkraav lkraav deleted the storybook-deployer-bump-2-8-8 branch May 13, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants