-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Django 1.11 #1111
Comments
Checklist:
|
django-environ 0.4.2 confirm support for django 1.11 LTS |
django-anymail support for django 1.11 https://github.com/anymail/django-anymail/releases/tag/v0.9 |
django-extensions support for django 1.11 https://github.com/django-extensions/django-extensions/blob/master/CHANGELOG.md#178 |
django-model-utils support for django 1.11 https://github.com/jazzband/django-model-utils/blob/master/CHANGES.rst#300-20170413 |
django-debug-toolbar works for Django 1.11. |
whitenoise works for Django 1.11 https://travis-ci.org/evansd/whitenoise |
django-redis works for Django 1.11 https://travis-ci.org/niwinz/django-redis |
django-crispy-froms. Looks like there tests are running against django 1.11 django-crispy-forms/django-crispy-forms@d3bf1f2 |
django all_auth Tests passing with support for Django 1.11 |
django-storages tests passing for support with Django 1.11 |
pytest-django now supports 1.11 |
migrate from django-storages-redux to django-storages done in #1269 |
opbeat likely supports Django 1.11. Is there a particular issue with opbeat, or reason to suspect that it doesn't support 1.11? |
opbeat indicates it should work with Django 1.11:
|
The django-factory-boy package referenced above is different from the factory-boy used in cookiecutter-django -- factory-boy already supports Django 1.11: FactoryBoy/factory_boy#357 |
@reggieriser my mistake. I updated to the correct link. |
If my PR is accepted, we can remove django-braces from the 1.11-compatibility list: |
@kennethlove commented in the django-braces issue:
|
Thanks |
Maybe we could drop |
I think @pydanny wants to avoid running django-extensions on production. There's an issue about that, but I can't find it right now :/ |
I believe that factory_boy now supports Django 1.11 |
The problem with django-extensions is that it includes security issues like providing a fancy shell that arguably shouldn't be in production. And who knows what other magic has been added to that crazy mix of packages. That said, if django-autoslug is a blocker, let's not worry about it. If a malignant or foolish user can activate a fancy django-extensions shell in production, they've gotten in and there's nothing stopping them from unleashing destruction in their wake anyway. |
Got a response on django-autoslug re: 1.11 support:
|
Django 2.0 alpha 1 has just been released (final coming in about two months). I noticed this from the pre-release notes:
Is anybody actively working on the 1.11 upgrade? I'll be glad to help or research. |
@reggieriser feel free to do a pull-request to update to 1.11 (and make update to 2.0 more easy). Any help is welcome. |
When will django 1.11 cookiecutter get released? Thanks :) |
@yujinyuz you can run Cookiecutter Django and bump the Django version to 1.11 and it should work except in a few resolvable edge cases. |
I sent an email to the author of django-autoslug on October 14th offering to help with getting a new release out. So far no response. |
At this point I think we should remove that project as a dependency, either replacing with something else or discarding it entirely. Thoughts? |
A quick GitHub search reveals django-uuslug, for instance. |
It seems to be way more simpler when contrasted with |
Considering that we've waited this long, I think simpler choice for slug going forward is the better option. |
Hopefully, I will have time to take a look at it tomorrow to see how it'd be best to migrate. |
Two Scoops of Django seems to be recommending Wait : There is an article by Pydanny mentioned on Two Scoops and the maintainer seems to be pydanny . What? http://pydanny.com/awesome-slugify-human-readable-url-slugs-from-any-string.html Edit: So, it's a model field. Cool! A lot of people from |
With the release of Django 2.0 is this still valid? Should the aim still be to support Django 1.11 for it's LTS or should this move towards Django 2.0? |
@Tafkas Ideally you'd have support for a Django version until it's support in Django ends. For Django 1.11 it's |
I plan to look at this in the next day or so. |
How can I go with this cookiecutter and Django 2 please ? |
Yes, just run it and then do pip install -U Django. Works fine for me. That we haven't finished this ticket is because were volunteers. |
For what it's worth, I started a new project using this cookiecutter today, upgraded the resulting code to Django 1.11 and I deployed it to Heroku without any problems.
As far as I'm concerned, this issue (1.11) is resolved. Hopefully, some other folks could test other platforms and it would be a matter of sending a PR to change the requirements and a couple of places in the docs? |
Woohoo! Now for 2.0 support (#1416) hehe :-) |
We just bumped it to 1.11 in 5395687. |
So |
Sorry, @Evilplanet, but upgrades to existing projects is outside the scope of Cookiecutter Django. You should consider opening a question on Stack Overflow. |
I see. Thank you! |
Doing the first app (http://cookiecutter-django.readthedocs.io/en/latest/my-favorite-cookie.html) with cookie cutter and getting errors. I have the correct version of django installed - conn = _connect(dsn, connection_factory=connection_factory, **kwasync) |
@rossparks I'm sorry you are having difficulties, but your question is completely, 100% unrelated to migrating this project to Django 1.11. Furthermore, this issue is closed. Don't hijack issues, especially closed ones. If you have a problem, please open a new issue. |
I've told the bot to stay on
1.10.x
for now (f62e05b) and merged the latest security release.I believe @luzfcb was working on a release checklist. Let's put this here.
The text was updated successfully, but these errors were encountered: