Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Django 1.11 #1111

Closed
jayfk opened this issue Apr 5, 2017 · 49 comments
Closed

Update to Django 1.11 #1111

jayfk opened this issue Apr 5, 2017 · 49 comments

Comments

@jayfk
Copy link
Collaborator

jayfk commented Apr 5, 2017

I've told the bot to stay on 1.10.x for now (f62e05b) and merged the latest security release.

I believe @luzfcb was working on a release checklist. Let's put this here.

@luzfcb
Copy link
Collaborator

luzfcb commented Apr 6, 2017

Checklist:

@joke2k
Copy link

joke2k commented Apr 13, 2017

django-environ 0.4.2 confirm support for django 1.11 LTS
https://github.com/joke2k/django-environ#changelog

@dgorobets
Copy link

django-anymail support for django 1.11 https://github.com/anymail/django-anymail/releases/tag/v0.9

@dgorobets
Copy link

dgorobets commented Apr 17, 2017

django-extensions support for django 1.11 https://github.com/django-extensions/django-extensions/blob/master/CHANGELOG.md#178

@dgorobets
Copy link

django-model-utils support for django 1.11 https://github.com/jazzband/django-model-utils/blob/master/CHANGES.rst#300-20170413

@pydanny
Copy link
Member

pydanny commented Apr 17, 2017

django-debug-toolbar works for Django 1.11.

@ghost
Copy link

ghost commented May 25, 2017

whitenoise works for Django 1.11 https://travis-ci.org/evansd/whitenoise

@ghost
Copy link

ghost commented May 25, 2017

django-redis works for Django 1.11 https://travis-ci.org/niwinz/django-redis

@yunti
Copy link
Contributor

yunti commented Jun 12, 2017

django-crispy-froms. Looks like there tests are running against django 1.11 django-crispy-forms/django-crispy-forms@d3bf1f2

@yunti
Copy link
Contributor

yunti commented Jul 21, 2017

django all_auth Tests passing with support for Django 1.11
pennersr/django-allauth@fa07b32

@yunti
Copy link
Contributor

yunti commented Jul 21, 2017

django-storages tests passing for support with Django 1.11
jschneier/django-storages#295

@highpost
Copy link
Contributor

highpost commented Aug 8, 2017

pytest-django now supports 1.11
https://github.com/pytest-dev/pytest-django

@luzfcb
Copy link
Collaborator

luzfcb commented Aug 23, 2017

migrate from django-storages-redux to django-storages done in #1269

@brylie
Copy link

brylie commented Aug 30, 2017

opbeat likely supports Django 1.11. Is there a particular issue with opbeat, or reason to suspect that it doesn't support 1.11?

@brylie
Copy link

brylie commented Aug 30, 2017

opbeat indicates it should work with Django 1.11:

We run our test suite with Django 1.11, and have lots of customers running the Opbeat module on Django 1.11

opbeat/opbeat_python#183 (comment)

@reggieriser
Copy link
Contributor

The django-factory-boy package referenced above is different from the factory-boy used in cookiecutter-django -- factory-boy already supports Django 1.11: FactoryBoy/factory_boy#357

@luzfcb
Copy link
Collaborator

luzfcb commented Aug 31, 2017

@reggieriser my mistake. I updated to the correct link.

@reggieriser
Copy link
Contributor

If my PR is accepted, we can remove django-braces from the 1.11-compatibility list:
#1312

@brylie
Copy link

brylie commented Sep 6, 2017

@kennethlove commented in the django-braces issue:

Yeah, django-braces should be 100% compatible with all future Django releases unless they restructure how CBVs are constructed.

@jayfk
Copy link
Collaborator Author

jayfk commented Sep 6, 2017

Thanks

@webyneter
Copy link
Collaborator

Maybe we could drop django-autoslug in favor of django-extensions' AutoSlugField?

@jayfk
Copy link
Collaborator Author

jayfk commented Sep 8, 2017

I think @pydanny wants to avoid running django-extensions on production. There's an issue about that, but I can't find it right now :/

@highpost
Copy link
Contributor

highpost commented Sep 8, 2017

I believe that factory_boy now supports Django 1.11
https://github.com/FactoryBoy/factory_boy

@pydanny
Copy link
Member

pydanny commented Sep 8, 2017

The problem with django-extensions is that it includes security issues like providing a fancy shell that arguably shouldn't be in production. And who knows what other magic has been added to that crazy mix of packages.

That said, if django-autoslug is a blocker, let's not worry about it. If a malignant or foolish user can activate a fancy django-extensions shell in production, they've gotten in and there's nothing stopping them from unleashing destruction in their wake anyway.

@brylie
Copy link

brylie commented Sep 9, 2017

Got a response on django-autoslug re: 1.11 support:

The fixes for 1.10 on master (see justinmayer/django-autoslug#6) are working just fine for me on 1.11, however the maintainer has not released a new version since the changes were merged last October. :(

@eykd

@reggieriser
Copy link
Contributor

Django 2.0 alpha 1 has just been released (final coming in about two months). I noticed this from the pre-release notes:

Following the release of Django 2.0, we suggest that third-party app authors drop support for all versions of Django prior to 1.11.

Is anybody actively working on the 1.11 upgrade? I'll be glad to help or research.

@luzfcb
Copy link
Collaborator

luzfcb commented Sep 22, 2017

@reggieriser feel free to do a pull-request to update to 1.11 (and make update to 2.0 more easy). Any help is welcome.

@yujinyuz
Copy link

When will django 1.11 cookiecutter get released? Thanks :)

@pydanny
Copy link
Member

pydanny commented Oct 20, 2017

@yujinyuz you can run Cookiecutter Django and bump the Django version to 1.11 and it should work except in a few resolvable edge cases.

@jeffcjohnson
Copy link

I sent an email to the author of django-autoslug on October 14th offering to help with getting a new release out. So far no response.

@pydanny
Copy link
Member

pydanny commented Nov 4, 2017

At this point I think we should remove that project as a dependency, either replacing with something else or discarding it entirely. Thoughts?

@webyneter
Copy link
Collaborator

webyneter commented Nov 4, 2017

A quick GitHub search reveals django-uuslug, for instance.

@webyneter
Copy link
Collaborator

It seems to be way more simpler when contrasted with django-autoslug, though.

@pydanny
Copy link
Member

pydanny commented Nov 4, 2017

Considering that we've waited this long, I think simpler choice for slug going forward is the better option.

@webyneter
Copy link
Collaborator

webyneter commented Nov 4, 2017

Hopefully, I will have time to take a look at it tomorrow to see how it'd be best to migrate.

@Zerokami
Copy link

Zerokami commented Nov 5, 2017

Two Scoops of Django seems to be recommending awesome-slugify

Wait : There is an article by Pydanny mentioned on Two Scoops and the maintainer seems to be pydanny . What?

http://pydanny.com/awesome-slugify-human-readable-url-slugs-from-any-string.html

Edit: So, it's a model field. Cool!

A lot of people from cookiecutter seem to have posted issues on the django-autoslug project including one 12 hours ago.

@Tafkas
Copy link
Contributor

Tafkas commented Dec 3, 2017

With the release of Django 2.0 is this still valid? Should the aim still be to support Django 1.11 for it's LTS or should this move towards Django 2.0?

@Zerokami
Copy link

Zerokami commented Dec 4, 2017

@Tafkas Ideally you'd have support for a Django version until it's support in Django ends.

For Django 1.11 it's atleast Until April 2020

@pydanny
Copy link
Member

pydanny commented Dec 4, 2017

I plan to look at this in the next day or so.

@odeckmyn
Copy link

How can I go with this cookiecutter and Django 2 please ?

@pydanny
Copy link
Member

pydanny commented Dec 19, 2017

Yes, just run it and then do pip install -U Django. Works fine for me.

That we haven't finished this ticket is because were volunteers.

@browniebroke
Copy link
Member

For what it's worth, I started a new project using this cookiecutter today, upgraded the resulting code to Django 1.11 and I deployed it to Heroku without any problems.

  • Homepage works
  • Static files are collected OK
  • Created a super-user
  • Logged into the admin

As far as I'm concerned, this issue (1.11) is resolved. Hopefully, some other folks could test other platforms and it would be a matter of sending a PR to change the requirements and a couple of places in the docs?

@brylie
Copy link

brylie commented Dec 28, 2017

Woohoo! Now for 2.0 support (#1416) hehe :-)

@pydanny
Copy link
Member

pydanny commented Dec 28, 2017

We just bumped it to 1.11 in 5395687.

@pydanny pydanny closed this as completed Dec 28, 2017
@technolingo
Copy link

So django-autoslug was replaced with awesome-slugify? Could someone tell me how to update my existing project to Django 1.11? Thank you!

@pydanny
Copy link
Member

pydanny commented Dec 30, 2017

Sorry, @Evilplanet, but upgrades to existing projects is outside the scope of Cookiecutter Django. You should consider opening a question on Stack Overflow.

@technolingo
Copy link

I see. Thank you!

@rossparks
Copy link

Doing the first app (http://cookiecutter-django.readthedocs.io/en/latest/my-favorite-cookie.html) with cookie cutter and getting errors.

I have the correct version of django installed -

conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
psycopg2.OperationalError: fe_sendauth: no password supplied

@pydanny
Copy link
Member

pydanny commented Apr 16, 2018

@rossparks I'm sorry you are having difficulties, but your question is completely, 100% unrelated to migrating this project to Django 1.11. Furthermore, this issue is closed.

Don't hijack issues, especially closed ones.

If you have a problem, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests