Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt showing too soon #18

Closed
davidem opened this issue Jul 17, 2024 · 3 comments
Closed

Prompt showing too soon #18

davidem opened this issue Jul 17, 2024 · 3 comments

Comments

@davidem
Copy link
Contributor

davidem commented Jul 17, 2024

Hi there, me again. I've found another thing that I can't fix myself.

The bootsequence works with v2.42.2 and is called 'onInit', but apparently the prompt already shows. It didn't show this behaviour in v2.35.1. See attached recording.

Screen.Recording.2024-07-17.at.21.41.33.mov

Not sure it is because of your rework. It looks like the bugs 934 and 938 over at jquery.terminal, but they appear to be fixed.

@coolapso
Copy link
Owner

That I think may be because of the way you implemented your boot sequence. it seems to show between "boot sequences" try putting everything here inside the same timeoutFunctio() instead of having multiple ones

@davidem
Copy link
Contributor Author

davidem commented Jul 20, 2024

I've added everyting in a single loop now (as can be seen here), but even then the prompt is showing. Or does your remark still apply here? 😬

@coolapso
Copy link
Owner

coolapso commented Aug 2, 2024

not really what I meant but been quite busy lately, not really with the time to tinker with this :/

but again, I still believe its not related with the latest changes or with the template itself, but rather how you are implementing the boot sequence. I may be completely wrong as well, so if you find that it was actually something on my end feel free to let me know and i'll fix it. Also If you manage to make the boot sequence more re-usable I'd be happy to integrate it.

Maybe on the yaml file create an array just for the boot sequence.

params:
  bootsequence:
     boot0: | 
     boot1: |
     boot2: |
     ...

and loop over the different the bootsequence instead of having each section of the boot sequence as a key in the params root.
didn't give much thought to it, just throwing some options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants