Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: do not attempt expensive operations at every iteration of the wait loop #3773

Open
btovar opened this issue Apr 22, 2024 · 0 comments
Open
Labels

Comments

@btovar
Copy link
Member

btovar commented Apr 22, 2024

Both the check for fixed inputs and scheduling of replicas are potentially time consuming:

  • They should not be attempted at every iteration. For example, they can be called only N number of seconds apart, or perhaps only once per vine_wait call.
  • They should not go through all the possible queued items. For example, the scheduling of replicas should use HASH_TABLE_ITERATE_FROM_KEY and only try to schedule for M number of files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant