Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded dates in SushiService #484

Closed
vinny75 opened this issue Sep 13, 2018 · 5 comments
Closed

Hard-coded dates in SushiService #484

vinny75 opened this issue Sep 13, 2018 · 5 comments
Labels
bug This is a bug (not an enhancement)

Comments

@vinny75
Copy link
Contributor

vinny75 commented Sep 13, 2018

Was running into a problem where SUSHI was only pulling Jan-2018 through Feb-2018 despite setting the dates to something else. Think I have tracked the problem down to these two lines in SushiService.php from commit 8ccb533

614 $startDateArr = explode("-", '2018-01-01');
615 $endDateArr = explode("-", '2018-02-28');

Changing these two lines fixed the problem for me

614 $startDateArr = explode("-", '$this->startDate);
615 $endDateArr = explode("-", $this->endDate);

@LibClaire
Copy link

I can confirm that this worked as a fix for us too. Our SUSHI stats are now good!

@veggiematts
Copy link
Contributor

@queryluke Was there a reason you put fixed dates in your commit or was this a mistake? (I would go for the mistake, but still asking to be sure)

@queryluke
Copy link
Contributor

Yes, that seems like a mistake. Sorry about that. I probably hardcoded for testing and forgot to switch it back.

@veggiematts
Copy link
Contributor

Okay, thanks.

@jeffnm jeffnm added the bug This is a bug (not an enhancement) label Oct 23, 2018
@jeffnm
Copy link
Contributor

jeffnm commented Oct 23, 2018

A fix has been merged and will be included in the next release.

@jeffnm jeffnm closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug (not an enhancement)
Projects
None yet
Development

No branches or pull requests

5 participants