Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return value of wallet.signTransaction is ignored #1529

Closed
robert-balcerowicz opened this issue Feb 28, 2022 · 0 comments · Fixed by #1527
Closed

Return value of wallet.signTransaction is ignored #1529

robert-balcerowicz opened this issue Feb 28, 2022 · 0 comments · Fixed by #1527

Comments

@robert-balcerowicz
Copy link
Contributor

To integrate Web3Auth with Anchor I had to create a custom wallet adapter. This seemed to be a trivial task at first, however I've encountered a problem with signatures not being added to transaction. After debugging I've noticed inconsistency between TypeScript typings and actual function usage. Return value of wallet.signTransaction is ignored and this method is expected to mutate transaction object instead which is unintuitive and inconsistent with wallet.signTransactions method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant