Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts: difference between has_one and belongs_to? #435

Closed
fanatid opened this issue Jun 28, 2021 · 2 comments · Fixed by #459
Closed

Accounts: difference between has_one and belongs_to? #435

fanatid opened this issue Jun 28, 2021 · 2 comments · Fixed by #459
Labels
lang

Comments

@fanatid
Copy link
Contributor

fanatid commented Jun 28, 2021

Currently anchor have two attributes for Attribute derive macro: has_one and belongs_to. Doc for has_one:

Semantically different, but otherwise the same as belongs_to.

In the source code, we have only BelongsTo. Maybe it worth left only one and deprecate another? Allowing to developer do same thing by two different attribute does not looks good =\
@armaniferrante
Copy link
Member

Agreed we should remove one. I'm in favor for keeping has_one and removing belongs_to. What do others think?

@fanatid
Copy link
Contributor Author

fanatid commented Jun 29, 2021

I'm ok with has_one. Maybe start the poll in the anchor channel in discord with pinning @everyone?

@fanatid fanatid mentioned this issue Jul 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lang
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lang: remove belongs_to in favour of has_one fanatid/anchor
2 participants
@fanatid @armaniferrante