Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using repr(C) instead of repr(packed) for zero_copy? #813

Closed
dovahcrow opened this issue Sep 29, 2021 · 2 comments · Fixed by #1106
Closed

Using repr(C) instead of repr(packed) for zero_copy? #813

dovahcrow opened this issue Sep 29, 2021 · 2 comments · Fixed by #1106

Comments

@dovahcrow
Copy link

As mentioned in this issue rust-lang/rust#82523, creating references to packed fields will be an error in the future.
@y2kappa
Copy link
Contributor

y2kappa commented Dec 5, 2021

will this make some accounts larger? even so, I think it's much better than deploying something to production and later not be able to compile when it becomes an error

@y2kappa y2kappa mentioned this issue Dec 5, 2021
Merged
@dovahcrow
Copy link
Author

will this make some accounts larger? even so, I think it's much better than deploying something to production and later not be able to compile when it becomes an error

I think so if the fields are not properly arranged previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Repr C for zero_copy y2kappa/anchor
2 participants
@dovahcrow @y2kappa