Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lambda-manager code to trigger on creation [CDS-1331] #151

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Jun 24, 2024

Description

When a user sets the parameter ScanOldLogGroups to true then right now the lambda will not get trigger on creation to add all of the old log groups, it will only get triggered when a new log group is created.
UPdate the python code and added custom trigger to the template so in case that ScanOldLogGroups is set to true then the lambda will add all of the existing log groups as triggers to the lambda / firehose

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the changed module in the template index.js and package.json files.
  • I have updated the relevant component changelog(s)
  • This change does not affect module (e.g. it's readme file change)

Copy link
Collaborator

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guyrenny guyrenny merged commit ba6f883 into master Jun 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants