Create a new variable LogGroupPermissionPreFix and update the python code [CDS-1331] #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… have more then 50 lo groups, and rewite most of the python code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the lambda will add permission for each of the log groups to the destination lambda, this can hit an AWS limitation for the number of permissions. Added a new variable
LogGroupPermissionPreFixso that when it's defined the lambda will create permissions using the log group prefix from the parameter and wildcard (*) instead of creating 1 permission for each log group this will help avoid the AWS limitation.ReWrite most of the Python lambda code for it to work with the new parameter.
Description
Fixes #How Has This Been Tested?
Checklist: