Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events2metrics buckets float conversion bug #225

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Events2metrics buckets float conversion bug #225

merged 2 commits into from
Apr 19, 2024

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Apr 19, 2024

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@OrNovo OrNovo marked this pull request as ready for review April 19, 2024 10:35
@OrNovo OrNovo requested a review from a team as a code owner April 19, 2024 10:35
@OrNovo OrNovo requested a review from oded-dd April 19, 2024 10:35
@OrNovo OrNovo merged commit b52c5de into master Apr 19, 2024
5 of 6 checks passed
@OrNovo OrNovo deleted the events2metrics_buckets_float_conversion_bug branch April 19, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oded-dd oded-dd oded-dd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrNovo @oded-dd