Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch - adding 5Min option to time_window for unique_count #234

Merged
merged 4 commits into from
Jun 9, 2024
Merged

patch - adding 5Min option to time_window for unique_count #234

merged 4 commits into from
Jun 9, 2024

Conversation

OrNovo
Copy link
Contributor

@OrNovo OrNovo commented Jun 9, 2024

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@OrNovo OrNovo marked this pull request as ready for review June 9, 2024 13:35
@OrNovo OrNovo requested a review from a team as a code owner June 9, 2024 13:35
@OrNovo OrNovo merged commit 9ce00f6 into master Jun 9, 2024
5 of 7 checks passed
@OrNovo OrNovo deleted the adding_5Min_to_unique_count branch June 9, 2024 13:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

🎉 This PR is included in version 1.15.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oded-dd oded-dd oded-dd approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrNovo @oded-dd