Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index accesses from Azure provider #111

Open
csssuf opened this issue Aug 3, 2018 · 1 comment
Open

Remove index accesses from Azure provider #111

csssuf opened this issue Aug 3, 2018 · 1 comment

Comments

@csssuf
Copy link
Contributor

csssuf commented Aug 3, 2018

Bug

coreos-metadata Version

1.0.0+

Environment

Azure

Expected Behavior

The Azure provider should not use index accesses, as they can cause panics.

Actual Behavior

The Azure provider uses index accesses here and here.

@sdemos
Copy link
Contributor

sdemos commented Aug 3, 2018

More generally, I think it would be useful to audit the entire codebase for "things that can panic" and remove them wherever possible. I think we pretty much always want explicit error handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants