Add NoSync field to Options #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylertreat squash to a single commit? |
This allows enabling NoSync when you only have access to the Options passed into Open() and not the returned DB (as is frequently the case with libraries).
tylertreat
force-pushed
the
nosync_option
branch
from
bdc3048
to
69fa13f
Compare
|
@heyitsanthony done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change to expose
NoSyncinOptions. Hopefully this is a reasonable change. The justification for this is I use a number of libraries which simply expose theOptionspassed intoOpen()but not the underlyingDBthey create. To enableNoSyncin these cases, I either have to fork the library or fork bolt.