db.go: return t.Rollback directly in the end of View function #41
Conversation
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
=========================================
Coverage ? 84.91%
=========================================
Files ? 9
Lines ? 1849
Branches ? 0
=========================================
Hits ? 1570
Misses ? 166
Partials ? 113
Continue to review full report at Codecov.
|
| @@ -687,9 +687,7 @@ func (db *DB) View(fn func(*Tx) error) error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := t.Rollback(); err != nil { | |||
There was a problem hiding this comment.
I think the intent here is to avoid using unexported functions across object boundaries to avoid tight coupling.
It'd probably be better to have:
return t.Rollback()
}which would directly correspond with the Update code. Rollback is the method for closing read-only transactions; close is atypical.
There was a problem hiding this comment.
Make sense to me. tx.close is tx's own function. And return t.Rollback() matches return t.Commit() in Update function.
I'll update this commit later.
Make return line of db.View corresponding with db.Update.
lorneli
changed the title
|
lgtm |
gyuho
changed the title
Calling t.Rollback is a little bit misleading in the end of View function, since this tx has succeeded. What t.Rollback actually does here is closing this tx. So close tx directly.