Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx: use io.SeekStart in WriteTo function #43

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

lorneli
Copy link
Contributor

@lorneli lorneli commented Sep 11, 2017

Const os.SEEK_SET is deprecated. See https://golang.org/pkg/os/#pkg-variables.

Const os.SEEK_SET is deprecated.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4ff482b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage          ?   84.81%           
=========================================
  Files             ?        9           
  Lines             ?     1851           
  Branches          ?        0           
=========================================
  Hits              ?     1570           
  Misses            ?      167           
  Partials          ?      114
Impacted Files Coverage Δ
tx.go 76% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff482b...4ce1b5e. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Sep 12, 2017

lgtm.

defer to @heyitsanthony

@heyitsanthony
Copy link
Contributor

lgtm

@heyitsanthony heyitsanthony merged commit cca7a90 into etcd-io:master Sep 12, 2017
@lorneli lorneli deleted the bbolt_seek branch September 13, 2017 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants