tx.go: just close file once in WriteTo function #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage ? 85.52%
=========================================
Files ? 9
Lines ? 1851
Branches ? 0
=========================================
Hits ? 1583
Misses ? 159
Partials ? 109
Continue to review full report at Codecov.
|
heyitsanthony
suggested changes
Sep 12, 2017
tx.go
Outdated
| @@ -317,7 +317,11 @@ func (tx *Tx) WriteTo(w io.Writer) (n int64, err error) { | |||
| if err != nil { | |||
| return 0, err | |||
| } | |||
| defer func() { _ = f.Close() }() | |||
| defer func() { | |||
| if err != nil { | |||
There was a problem hiding this comment.
This will still double close when return n, f.Close() has an error. Try return n, nil and
defer func() {
if cerr := f.Close(); err == nil {
err = cerr
}
}
WriteTo function closes file twice in normal path previously.
|
lgtm |
heyitsanthony
approved these changes
Sep 14, 2017
gyuho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteTo function closes file twice in normal path previously.