Fix freelist corruption on tx.WriteTo #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was causing freelist corruption on tx.WriteTo
Reliably triggers consistency check failures on ramdisk without freelist free fix.
heyitsanthony
changed the title
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage ? 85.47%
=========================================
Files ? 9
Lines ? 1859
Branches ? 0
=========================================
Hits ? 1589
Misses ? 160
Partials ? 110
Continue to review full report at Codecov.
|
|
lgtm |
ahrtr
reviewed
Jun 27, 2024
Comment on lines
133
to
+137
| if ok { | ||
| delete(f.allocs, p.id) | ||
| } else if (p.flags & (freelistPageFlag | metaPageFlag)) != 0 { | ||
| // Safe to claim txid as allocating since these types are private to txid. | ||
| allocTxid = txid | ||
| } else if (p.flags & freelistPageFlag) != 0 { | ||
| // Freelist is always allocated by prior tx. | ||
| allocTxid = txid - 1 |
There was a problem hiding this comment.
It can fix the issue, but it's a little complicated. No need to handle freelist as a special case. I think it can be as simple as below.
$ git diff
diff --git a/freelist.go b/freelist.go
index fdf8a36..4a15832 100644
--- a/freelist.go
+++ b/freelist.go
@@ -118,9 +118,6 @@ func (f *freelist) free(txid common.Txid, p *common.Page) {
allocTxid, ok := f.allocs[p.Id()]
if ok {
delete(f.allocs, p.Id())
- } else if p.IsFreelistPage() {
- // Freelist is always allocated by prior tx.
- allocTxid = txid - 1
}
for id := p.Id(); id <= p.Id()+common.Pgid(p.Overflow()); id++ {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lol