Madvise optional #82
Merged
Madvise optional #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=========================================
Coverage ? 85.58%
=========================================
Files ? 9
Lines ? 1859
Branches ? 0
=========================================
Hits ? 1591
Misses ? 158
Partials ? 110
Continue to review full report at Codecov.
|
xiang90
reviewed
Feb 22, 2018
bolt_unix.go
Outdated
| @@ -56,7 +56,10 @@ func mmap(db *DB, sz int) error { | |||
| } | |||
|
|
|||
| // Advise the kernel that the mmap is accessed randomly. | |||
| if err := madvise(b, syscall.MADV_RANDOM); err != nil { | |||
| err = madvise(b, syscall.MADV_RANDOM) | |||
| if err == syscall.ENOSYS { | |||
There was a problem hiding this comment.
if err!=nil && err!=syscall.ENOSYS
|
lgtm. can you squash the commits into one? |
|
done origin/master is merged so that's why other files looks changed. |
|
@honteng Can you revert the merge commit? Just your patch should work. |
|
ok, I removed. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenWRT Linux kernel doesn't support madvise syscall. It always returns "function not implemented" error, but it still works fine. This should be optional check.