Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Close() to also wait for view transactions and fix tests as well #91

Merged
merged 4 commits into from
Aug 28, 2018

Conversation

vansante
Copy link
Contributor

For more details about the bug see here:
#90

@vansante vansante changed the title Fix Close() to also wait for view transactions and fix TestDB_Close_PendingTx_RO test as well Fix Close() to also wait for view transactions and fix tests as well Mar 29, 2018
@xiang90
Copy link
Contributor

xiang90 commented Aug 25, 2018

can you also change the documentation to make this clear?

@vansante
Copy link
Contributor Author

I could, but IMHO the documentation is pretty clear already:

https://github.com/coreos/bbolt/blob/master/db.go#L448

Close releases all database resources. It will block waiting for any open transactions to finish before closing the database and returning.

What do you propose to change it to?

@xiang90
Copy link
Contributor

xiang90 commented Aug 25, 2018

ah. ok.

@gyuho can you get this merged?

@gyuho
Copy link
Contributor

gyuho commented Aug 25, 2018

@xiang90 I have no write access to coreos anymore. Will merge and release a new bbolt on Monday.

@xiang90 xiang90 merged commit e06ec0a into etcd-io:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants