Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sugar for .container systemd quadlet units #497

Open
jbtrystram opened this issue Oct 10, 2023 · 5 comments
Open

Add sugar for .container systemd quadlet units #497

jbtrystram opened this issue Oct 10, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@jbtrystram
Copy link

The following butane config fails to transpile :

variant: fcos
version: 1.5.0
systemd:
  units:
    - name: target
      enabled: true
      contents_local: target.container

when ran :

$ podman run --rm -v ./:/srv:z quay.io/coreos/butane:release --pretty --strict -d /srv /srv/target.bu > transpiled_config.ign
error at $.systemd.units.0.name, line 14 col 13: invalid systemd unit extension
Error translating config: config generated was invalid

https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html

@jbtrystram jbtrystram self-assigned this Oct 10, 2023
@jbtrystram jbtrystram transferred this issue from coreos/butane Oct 10, 2023
@travier
Copy link
Member

travier commented Oct 10, 2023

Quadlets are "just" files in /etc/containers/systemd/ so there is nothing to add in Ignition. Butane could grow some validation logic but not usre how much that would be useful / comprehensive.

@travier
Copy link
Member

travier commented Oct 10, 2023

Moving back to Butane.

@travier travier transferred this issue from coreos/ignition Oct 10, 2023
@travier travier changed the title Support for .container systemd quadlet units Add sugar for .container systemd quadlet units Oct 10, 2023
@travier travier added the enhancement New feature or request label Oct 10, 2023
@stocky37
Copy link

For what it's worth, I also ran it into this just now. It still occurs when using target.container as the unit name.

@travier
Copy link
Member

travier commented Dec 20, 2023

For what it's worth, I also ran it into this just now. It still occurs when using target.container as the unit name.

This happens because quadlet are not systemd units, so you can not use this syntax to set them in Butane.

See https://github.com/travier/fedora-coreos-matrix for an example config using quadlets.

@stocky37
Copy link

Yeah, makes sense. Thanks for the example config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants