Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline stream name to containers as labels #3390

Open
jlebon opened this issue Mar 13, 2023 · 1 comment
Open

Add pipeline stream name to containers as labels #3390

jlebon opened this issue Mar 13, 2023 · 1 comment

Comments

@jlebon
Copy link
Member

jlebon commented Mar 13, 2023

Feature Request

Desired Feature

The release controller wants to be able to tell from which stream an RHCOS build came from just by looking at its container image as found in the release payload. That way, it can link to the right stream in the RHCOS release browser.

Let's add a label for this to the image to make that easier. For consistency, we should probably add it to all the containers and not just the main one (i.e. the extensions container too).

Example Usage

UX to be discussed. We want to avoid passing switches; that won't work as nicely for the extensions container. Probably simplest is to drop a file in src/ at the top and have cosa pick up on that.

Other Information

See openshift/release-controller#503 (comment) and following.

@jlebon
Copy link
Member Author

jlebon commented May 19, 2023

We should also fix #3480 when we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant