Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cosa build --force=image to only rebuild the image #744

Closed
jlebon opened this issue Sep 12, 2019 · 3 comments · Fixed by #767
Closed

Add cosa build --force=image to only rebuild the image #744

jlebon opened this issue Sep 12, 2019 · 3 comments · Fixed by #767
Labels
good-first-issue good issue for someone new

Comments

@jlebon
Copy link
Member

jlebon commented Sep 12, 2019

Feature Request

Desired Feature

A cosa build --force=image which disregards the image input check so we always rebuild the image. That way we don't have to keep faking it by e.g. editing image.yaml. Proposed in #741 (comment).

Example Usage

cosa build --force=image
@Prashanth684
Copy link
Contributor

I'd like to take this on if nobody else is working on it.

@Prashanth684
Copy link
Contributor

do we need to bother to support the short option "-f" with this change ? or should we remove the -f completely ?

@jlebon
Copy link
Member Author

jlebon commented Sep 16, 2019

I don't think we should drop it. It should just keep meaning the same thing as --force (i.e. force an OSTree rebuild).

One thought related to this issue: I'm thinking it'd be better to just have a --force-image switch instead. The reason is that I think optional arguments are a pretty common footgun (i.e. --force=image vs. --force image).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue good issue for someone new
Projects
None yet
2 participants