Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreos-install iso embed --no-initramfs-networking #164

Closed
cgwalters opened this issue Feb 18, 2020 · 8 comments
Closed

coreos-install iso embed --no-initramfs-networking #164

cgwalters opened this issue Feb 18, 2020 · 8 comments

Comments

@cgwalters
Copy link
Member

cgwalters commented Feb 18, 2020

For the use case of static IPs on bare metal, we have coreos-install iso embed to insert Ignition, but that still has an implicit requirement on DHCP.

Let's add an option to embed that turns it off, like:

$ coreos-install iso embed --no-initramfs-networking -c /path/to/config.ign /path/to/foo.iso
@cgwalters cgwalters changed the title coreos-install iso disable-initrd-networking coreos-install iso embed --nonet Feb 18, 2020
@cgwalters cgwalters changed the title coreos-install iso embed --nonet coreos-install iso embed --no-initramfs-networking Feb 18, 2020
@bgilbert
Copy link
Contributor

This seems like a special case of a more general thing I've proposed before (though apparently I never filed a bug about it): provide an option for embedding any karg interpreted by Dracut, including the networking options generally. It'd be easy to implement (drop a file in /etc/cmdline.d in the CPIO archive), but a hard distinction to make to the user, who can't be expected to know which kargs are implemented where.

Thoughts?

@cgwalters
Copy link
Member Author

Definitely related, although this gets into a few interesting details - among them that there's not really a standard way to remove a kernel argument, which is relevant here for disabling networking that is enabled by default.

@jlebon
Copy link
Member

jlebon commented Feb 19, 2020

We wouldn't need to remove a karg I think, just append rd.neednet=0. And hmm... actually, it'd probably work today to do coreos-installer install --firstboot-args rd.neednet=0?

@bgilbert
Copy link
Contributor

I'd guess rd.neednet=0 would work. The issue is the live ISO boot, not the boot of the installed system, so --firstboot-args is too late.

@cgwalters
Copy link
Member Author

I guess we could generalize this to --initialboot-args. I agree that appending rd.neednet=0 likely works in practice and would be fine, but it just feels less clean than actually removing the argument.

@jlebon
Copy link
Member

jlebon commented Mar 31, 2020

This is part of the more generic conditional networking issue: coreos/fedora-coreos-tracker#443.

@dustymabe
Copy link
Member

For the use case of static IPs on bare metal, we have coreos-install iso embed to insert Ignition, but that still has an implicit requirement on DHCP.

After coreos/fedora-coreos-config#326 the Live ISO image no longer requires DHCP.

@jlebon
Copy link
Member

jlebon commented Jul 6, 2021

The ISO (as with all the other artifacts) no longer default to initramfs networking. So closing this.

@jlebon jlebon closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants