Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Example etcd-backup-operator has no image #1649

Closed
akauppi opened this issue Nov 9, 2017 · 5 comments
Closed

Example etcd-backup-operator has no image #1649

akauppi opened this issue Nov 9, 2017 · 5 comments

Comments

@akauppi
Copy link

akauppi commented Nov 9, 2017

The example etcd-backup-operator/deployment.yaml has:

image: <operator-image>

This is likely a placeholder that should get replaced by a proper image address, like quay.io/coreos/etcd-backup-operator:v0.6.1? If not, people need instructions on how to build such an image ourselves.

Related to: #1626

@akauppi akauppi changed the title Example etcd-backup-operator has no image Example etcd-backup-operator has no proper image Nov 9, 2017
@akauppi
Copy link
Author

akauppi commented Nov 9, 2017

This also applies to the etcd-restore-operator/deployment.yaml

@akauppi akauppi changed the title Example etcd-backup-operator has no proper image Example etcd-backup-operator has no image Nov 9, 2017
@fanminshi
Copy link
Contributor

@akauppi good catch. I'll improve the walkthrough.

in the meantime, you can to build the image with following.

building backup-operator image:

first, build operator binary:
./hack/build/backup-operator/build

then push your image with docker_push script:
IMAGE=<your-image-name> ./hack/build/docker_push

the build and push script is simple enough. you can read it yourself.

@akauppi
Copy link
Author

akauppi commented Nov 10, 2017

Thanks, @fanminshi

I noticed the build places all three operators in the same image (good approach), so one option for me would be simply to wait until the etcd-operator release that has them. Would that mean 0.7.0 and how much calendar time?

note: I had a look at ROADMAP but it seems out-of-date, so I need to ask... :)

I was able to build the image using your instructions and the Developer's Guide

@hongchaodeng
Copy link
Member

Yeah. ROADMAP is outdated. We now usually track roadmaps in github milestone and design docs.

@fanminshi
Copy link
Contributor

@akauppi 0.7.0 is released https://github.com/coreos/etcd-operator/releases/tag/v0.7.0. you should have no trouble of following the examples. Please let me know if you have any questions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants