Skip to content
This repository has been archived by the owner on Mar 28, 2020. It is now read-only.

Version selection assumes etcd image versions will begin with "v" #1974

Open
perotinus opened this issue Jun 25, 2018 · 2 comments
Open

Version selection assumes etcd image versions will begin with "v" #1974

perotinus opened this issue Jun 25, 2018 · 2 comments

Comments

@perotinus
Copy link

The code that constructs the etcd image version from the CRD spec prefixes the image version with a "v". This assumption breaks in some contexts where the released etcd images from quay.io are not beins used, and it would be useful to have a way to tell the operator to take the image version as-is, without inserting the extra "v" into the versioning scheme.

return fmt.Sprintf("%s:v%v", repo, version)

@perotinus
Copy link
Author

Looks like #1970 addresses this.

@prune998
Copy link

made a PR for the v addition to the version : #2079

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants